Skip to content

chore(commons): Remove eslint from commons pkg #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

Fixes #333

Changes:

  • Removed eslint config from commons package
  • Fixed linting issues

How to verify this change

Clone repo and/or review changes

Related issues, RFCs

#333

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Dec 28, 2021
@dreamorosi dreamorosi added this to the beta-release milestone Dec 28, 2021
@dreamorosi dreamorosi self-assigned this Dec 28, 2021
@flochaz flochaz changed the title (chore): Remove eslint from commons pkg chore(commons): Remove eslint from commons pkg Dec 28, 2021
@dreamorosi dreamorosi merged commit af1fe2b into main Dec 28, 2021
@dreamorosi dreamorosi deleted the chore/remove_eslint_commons branch December 28, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: use one eslint at root folder & fix linting issues
3 participants